Skip to content

Add config_flow for Roomba#33302

Merged
bdraco merged 111 commits intohome-assistant:devfrom
cyr-ius:roomba
Apr 11, 2020
Merged

Add config_flow for Roomba#33302
bdraco merged 111 commits intohome-assistant:devfrom
cyr-ius:roomba

Conversation

@cyr-ius
Copy link
Copy Markdown
Contributor

@cyr-ius cyr-ius commented Mar 27, 2020 •
edited by bdraco
Loading

Breaking change

The roomba integration can now be configured in the UI, and provides additional sensors.

The yaml configuration format has changed, and must be re-setup.

Proposed change

Add config_flow for iRobots Roomba

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: #12793

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Mar 27, 2020

Hey there @pschmitt, mind taking a look at this pull request as its been labeled with a integration (roomba) you are listed as a codeowner for? Thanks!

@pschmitt pschmitt mentioned this pull request Mar 27, 2020
Closed
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/vacuum.py
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/config_flow.py Outdated
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/config_flow.py Outdated
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/vacuum.py
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread tests/components/roomba/test_config_flow.py Outdated
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread tests/components/roomba/test_config_flow.py Outdated
bdraco
bdraco reviewed Mar 27, 2020
View reviewed changes
Comment thread tests/components/roomba/test_config_flow.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 27, 2020

@cyr-ius Does this need an upstream change in roombapy per pschmitt/roombapy#25?

bdraco
bdraco requested changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Please see my comments above.

@springstan springstan changed the title Config_flow Roomba Add config_flow for Roomba Mar 27, 2020
bdraco
bdraco reviewed Mar 28, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
bdraco
bdraco reviewed Apr 10, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
bdraco
bdraco reviewed Apr 10, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
bdraco
bdraco reviewed Apr 10, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
bdraco
bdraco reviewed Apr 10, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
bdraco
bdraco reviewed Apr 10, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

confirmed multiple roomba working now. Docs are almost there. Just that last bit of cleanup mentioned above and I think this is good to go! 🎉

cyr-ius and others added 5 commits April 11, 2020 14:23
@cyr-ius @bdraco
Update homeassistant/components/roomba/__init__.py
9daeeac 
Co-Authored-By: J. Nick Koston <nick@koston.org>
@cyr-ius @bdraco
Update homeassistant/components/roomba/__init__.py
d29d3dc 
Co-Authored-By: J. Nick Koston <nick@koston.org>
@cyr-ius @bdraco
Update homeassistant/components/roomba/__init__.py
f83beb9 
Co-Authored-By: J. Nick Koston <nick@koston.org>
@cyr-ius @bdraco
Update homeassistant/components/roomba/__init__.py
f2a40c9 
Co-Authored-By: J. Nick Koston <nick@koston.org>
@cyr-ius
Remove CONF_PREFIX (unused)
017e3e6
bdraco
bdraco reviewed Apr 11, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/sensor.py Outdated
bdraco
bdraco approved these changes Apr 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyr-ius and others added 2 commits April 11, 2020 15:52
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

Thanks. Retesting now

bdraco
bdraco reviewed Apr 11, 2020
View reviewed changes
Comment thread homeassistant/components/roomba/__init__.py Outdated
Comment thread homeassistant/components/roomba/__init__.py Outdated
cyr-ius and others added 2 commits April 11, 2020 16:11
@cyr-ius @bdraco
Update homeassistant/components/roomba/__init__.py
c70d2f6 
Co-Authored-By: J. Nick Koston <nick@koston.org>
@cyr-ius @bdraco
Update homeassistant/components/roomba/__init__.py
9da03a0 
Co-Authored-By: J. Nick Koston <nick@koston.org>
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020 •
edited
Loading

@cyr-ius Retested, everything looks good.

Since I'm the only one who has looked at this one, it is possible another reviewer may have additional change requests for a followup PR.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 11, 2020

@cyr-ius any more changes coming or ok to merge now?

@cyr-ius
Copy link
Copy Markdown
Contributor Author

cyr-ius commented Apr 11, 2020

OK merge now

@bdraco bdraco merged commit 8c4a139 into home-assistant:dev Apr 11, 2020
MartinHjelmare
MartinHjelmare reviewed Apr 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments in a new PR. Thanks!

Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/__init__.py
Comment thread homeassistant/components/roomba/binary_sensor.py
Comment thread homeassistant/components/roomba/binary_sensor.py
Comment thread homeassistant/components/roomba/binary_sensor.py
@cyr-ius cyr-ius mentioned this pull request Apr 12, 2020
Closed
20 tasks
@cyr-ius
Copy link
Copy Markdown
Contributor Author

cyr-ius commented Apr 12, 2020

I have made the requested changes in PR #34089

javicalle pushed a commit to javicalle/home-assistant that referenced this pull request Apr 12, 2020
@cyr-ius @bdraco @javicalle
Add config_flow for Roomba (home-assistant#33302)
87cd5c1 
* Add config_flow for roomba

* Get options to connect

* Fix options in config flow

* Fix syntax in config_flow

* Remove name (not necessary)

* Add bin sensor

* Add Battery sensor

* Add async_connect

* Fix typo

* Add Model and Software version

* Update Roombapy 1.5.0

* Add validate_input

* Add connect and disconnect functions

* Remove test config flow

* Add variables after loop

* Fix translate

* Fix typo

* Fix state of bin

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Remove invalid auth

* Add call function reported_state

* Add options reload

* Fix tracelog

* Set entry_id for config_entry

* Fix DOMAIN unsed-import

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Add unique_id for entry

* Fix device info

* Add config_flow for roomba

* Get options to connect

* Fix options in config flow

* Fix syntax in config_flow

* Remove name (not necessary)

* Add bin sensor

* Add Battery sensor

* Add async_connect

* Fix typo

* Add Model and Software version

* Update Roombapy 1.5.0

* Add validate_input

* Add connect and disconnect functions

* Remove test config flow

* Add variables after loop

* Fix translate

* Fix typo

* Fix state of bin

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Remove invalid auth

* Add call function reported_state

* Add options reload

* Fix tracelog

* Set entry_id for config_entry

* Fix DOMAIN unsed-import

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/config_flow.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Add unique_id for entry

* Fix device info

* syntax for mac (pyupgrade)

* Change single key to BLID

* Resolve dict conflict

* Update homeassistant/components/roomba/binary_sensor.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/sensor.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/.translations/en.json

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/strings.json

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Add description

* Revert "Remove test config flow"

This reverts commit 26a8942.

* Add tests

* Remove check if user none

* Replace CONF_USERNAME to CONF_BLID (breaking change)

* Update test_config_flow.py

* Add code owners

* Remove CONF_USERNAME (unused)

* Add multiple vacuum

* Add multiple vacuum

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Fix syntax name

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Remove CONF_PREFIX (unused)

* Update homeassistant/components/roomba/sensor.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Add import UNIT_PERCENTAGE

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

* Update homeassistant/components/roomba/__init__.py

Co-Authored-By: J. Nick Koston <nick@koston.org>

Co-authored-by: J. Nick Koston <nick@koston.org>
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdraco bdraco bdraco approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

+2 more reviewers

@freekode freekode freekode left review comments

@shenxn shenxn shenxn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change cla-signed has-tests integration: roomba

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cyr-ius @bdraco @frenck @freekode @MartinHjelmare @shenxn @homeassistant